cover: Gracefully handle failures to collect coverage data #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On platforms that support native coverage (introduced in Erlang/OTP 27), the `cover` module did not properly handle failed calls to `code:get_coverage/2`. The call to that function will fail if the module in question has been reloaded or unloaded. For example, if `cover:export/1` was called and a module had been reloaded on a remote node (for example by `meck`), the `cover:export/1` call would never return. Because the current API for `cover` has no good way to report this kind of error, we will fix the issue by logging the failed call using the `logger` module and otherwise ignore the failure. That implies that there will be no coverage information for modules that have been reloaded. That is compatible with the behavior of `cover` prior to Erlang/OTP 27. Closes erlang#8691
bjorng
added
team:VM
CT Test Results 2 files 22 suites 6m 14s ⏱️ Results for commit 426c582. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms that support native coverage (introduced in Erlang/OTP 27), the
covermodule did not properly handle failed calls tocode:get_coverage/2. The call to that function will fail if the module in question has been reloaded or unloaded.For example, if
cover:export/1was called and a module had been reloaded on a remote node (for example bymeck), thecover:export/1call would never return.Because the current API for
coverhas no good way to report this kind of error, we will fix the issue by logging the failed call using theloggermodule and otherwise ignore the failure. That implies that there will be no coverage information for modules that have been reloaded. That is compatible with the behavior ofcoverprior to Erlang/OTP 27.Closes #8691